fix: add fallback skin for invalid CustomNPC texture paths#244
Open
PeTcHeNkA wants to merge 3 commits intoKAMKEEL:masterfrom
Open
fix: add fallback skin for invalid CustomNPC texture paths#244PeTcHeNkA wants to merge 3 commits intoKAMKEEL:masterfrom
PeTcHeNkA wants to merge 3 commits intoKAMKEEL:masterfrom
Conversation
- Add empty string check in skinType 0 else branch - Set textureLocation to fallBackSkin(npc) for invalid textures - Add null safety check before returning textureLocation - Prevents transparent NPCs when invalid paths like "customnpcs:textures/entity/test.png" or "teststring" are used
…ture Previously, skinType==0 branch created a ResourceLocation directly without checking if the resource actually exists. This was inconsistent with adjustLocalTexture(), which probes the ResourceManager and falls back on missing assets. Now we call Minecraft.geMinecraft().getResourceManager().getResource(resLoc) and catch IOException. On failure, we fall back to a valid texture via fallBackSkin(npc), ensuring rendering always uses a valid path and avoiding invalid ResourceLocation assignments. This change aligns behavior across texture loading paths and prevents rendering errors when NPC textures are missing.
Contributor
Author
Before:
After:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds proper fallback to default skins (Steve/Alex) when invalid texture ResourceLocations are provided for CustomNPCs, preventing invisible/transparent NPCs from appearing.
Problem
When an invalid texture path like
customnpcs:textures/entity/test.pngor an empty string""is entered in the CustomNPC texture field, the NPC appears with a transparent texture instead of falling back to a default skin. While URL-based skins (skinType 2/3) already had fallback logic, local ResourceLocation textures (skinType 0) were missing validation and fallback handling.The specific issue was in the else branch of skinType 0 handling, where
new ResourceLocation(npc.display.texture)was created without checking ifnpc.display.texturewas empty or invalid.Changes
textureLocationtofallBackSkin(npc)when texture is empty or invalidgetEntityTexture()to ensure fallback is returned if textureLocation is still nullTesting
""customnpcs:textures/entity/nonexistent.png)