Fiex the bug from parse_result re.search function#270
Open
andrei-hanciu wants to merge 1 commit intoJuniper:masterfrom
Open
Fiex the bug from parse_result re.search function#270andrei-hanciu wants to merge 1 commit intoJuniper:masterfrom
andrei-hanciu wants to merge 1 commit intoJuniper:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this modification fixes the bug of the selection the wrong regex_command from the parser.yaml file and searching it in the target_command string from the hosts.yaml file: for example if during one iteration over all the parser files we have the regex_command="show\s+interfaces\s+TenGigE0/2/0/2" and the target_command="show interfaces TenGigE0/2/0/22" then the if re.search(regex_command, target_command, re.IGNORECASE) check from the parse_result function from open-nti.py script will return True but we need it to return False. For accomplishing this but we only need to add the terminating sign $ to the regex_command string so that it search and match the exact target_command.