Minor changes to parser and troubleshooting guide by pythonmagic · Pull Request #105 · Juniper/open-nti

pythonmagic · 2016-12-04T18:32:17Z

Changes:

1)  Show BGP summary parser - w/o IP address
2)  Additional Troubleshooting for Pyez data

The IP address is not required .This fixed the missing data in DB and Dashboard

Added additional troubleshooting step for Pyez related issue and/or error.

dgarros · 2016-12-04T20:45:04Z

@pythonmagic
Thanks a lot for this pull request, it's great to get external contributions.

I agree the BGP parser needs to be clean-up, it should not have an IP address define in the query.
I see few things that needs to be updated before we can merge this request. I'll provide my comments inline in the code

Thanks
Damien

dgarros · 2016-12-04T20:46:03Z

data/junos_parsers/show-bgp-summary.parser.yaml

-        method: xpath
-        xpath: //bgp-peer[peer-address='10.255.0.6']/output-messages
-        variable-name:  $host.protocols.bgp.summary.10.255.0.6.output-messages
+        xpath: //bgp-peer[peer-address=$key]/bgp-rib/received-prefix-count


It's great to have fixed bgp-rib/received-prefix-count but all the other variables have been deleted in the process.

Please can you add back all the variables with the same construct as bgp-rib/received-prefix-count

dgarros · 2016-12-04T20:47:05Z

docs/troubleshoot.rst

+
+#3 : Check log within the container**
+
+  ./docker.cli.sh


./docker.cli.sh is deprecated and will be remove soon, please can you change that with

make cli

dgarros · 2016-12-04T20:48:30Z

docs/troubleshoot.rst

+.. NOTE::
+   Destination tables will vary depending of the incoming traffic
+    - For MX > jnpr.jvision
+    - For QFX5100/EX4300 > jnpr.analyticsd


This section is not applicable as it for the data collection Agent w/ Netconf, the name of the measurements will be different

dgarros · 2016-12-04T20:49:01Z

docs/troubleshoot.rst

+    #DEBUG      10  
+
+
+  ./docker.cli.sh


Same as above, please replace with

make cli

Fixing the bgp parser to be used with IP address.

Added back few missed output element.

Modification made to correct errors.

pythonmagic · 2016-12-04T22:16:12Z

Made the changes to bgp parser and troubleshooting doc.

Updated show system-resource-monitor parser to collect data from all slot and also all the pfe on any give slot.

For Debugging Parser related issue troubleshooting step has been added to document for manually runing Data collection script withing the container.The console output is extremely helpful for understating and fixing the parser issue.

dgarros · 2016-12-14T16:37:29Z

Hi @pythonmagic

Strangely the tests are failing now, I noticed that you have a mistake on the file show-system-resource-monitor-summary.parser.yaml, at the beginning, you remove the p or parser.

Please could you try to add it back to see if this help ?

Also, I'm not sure to understand the changes in show-system-resource-monitor-summary.parser.yaml, please could you explain what you are trying change in this file.

thanks
Damien

Hi Damien, Fixed the typo in line one and added "p" to "parser" i had to change the parser since the older version did not collect all the required information and only after making below changes was i able to see the data been populated in influxdb. Changes: 1) resource-monitor-summary-fpc-information-summary -- added "fpc" in middle 15.x seem to have "resource-monitor-summary-information-summary" 16.x has "resource-monitor-summary-fpc-information-summary" 2) 16.x the CLI and XML output has been changed . Added extra line for extracting data from all PFE. (example : MPC 16x10 has max of 4 PFE) --------------- 16.2 Output: --------------- Resource Usage Summary Throttle : Enabled Heap Mem Threshold : 70 % IFL Counter Threshold : 95 % Filter Counter Threshold : 95 % Expansion Threshold : 95 % MFS threshold : 70 % Used : 0 Slot # 0 Client allowed : Yes Service allowed : Yes Client denied : 0 Service denied : 0 Heap memory used : 315679536 In % : 17 Filter memory IFL memory Expansion memory PFE # used | % used | % used | % 0 19681024 39 137272 0 0 0 1 19681024 39 137192 0 0 0 2 19681024 39 137112 0 0 0 3 19681024 39 137112 0 0 0 -------------- 15.x Output ------------- juniper@PE36> show system resource-monitor summary Resource Usage Summary Throttle : Enabled Heap Mem Threshold : 70 % IFL Counter Threshold : 70 % Filter Counter Threshold : 70 % Expansion Threshold : 95 % MFS threshold : 70 % Used : 0 Heap Filter mem IFL mem Expansion Client Client session service service session Slot # used % PFE # used % used % mem used % session denied count session denied count 4 221212848 11 0 86000 0 58016 0 67584 0 Allowed 0 Allowed 0 5 193658008 10 0 78432 0 51664 0 372224 0 Allowed 0 Allowed 0 7 195612760 10 0 78016 0 51248 0 75776 0 Allowed 0 Allowed 0 9 194490648 10 0 85888 0 59120 0 109568 0 Allowed 0 Allowed 0 10 250955920 13 0 79040 0 51840 0 153600 0 1 79824 0 52464 0 3102208 2 2 87152 0 59792 0 3113472 2 3 85920 0 59152 0 153088 0 Allowed 0 Allowed

pythonmagic added 2 commits December 4, 2016 13:19

Show BGP summary parser - w/o IP address

5902f3d

The IP address is not required .This fixed the missing data in DB and Dashboard

Additional Troubleshooting for Pyez data

1a43d24

Added additional troubleshooting step for Pyez related issue and/or error.

dgarros suggested changes Dec 4, 2016

View reviewed changes

pythonmagic added 3 commits December 4, 2016 16:34

show bgp neighbour parer w/o IP address

8f6586b

Fixing the bgp parser to be used with IP address.

Added back few missed output element.

4bd8211

Added back few missed output element.

Modification Juniper#2

8e09bca

Modification made to correct errors.

pythonmagic added 2 commits December 7, 2016 15:36

Updated show system-resource-monitor parser

cb0da9f

Updated show system-resource-monitor parser to collect data from all slot and also all the pfe on any give slot.

Update step fro debugging Parser

37c9d82

For Debugging Parser related issue troubleshooting step has been added to document for manually runing Data collection script withing the container.The console output is extremely helpful for understating and fixing the parser issue.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minor changes to parser and troubleshooting guide#105

Minor changes to parser and troubleshooting guide#105
pythonmagic wants to merge 8 commits intoJuniper:masterfrom
pythonmagic:master

pythonmagic commented Dec 4, 2016

Uh oh!

dgarros commented Dec 4, 2016

Uh oh!

dgarros Dec 4, 2016

Uh oh!

dgarros Dec 4, 2016

Uh oh!

dgarros Dec 4, 2016

Uh oh!

dgarros Dec 4, 2016

Uh oh!

pythonmagic commented Dec 4, 2016

Uh oh!

dgarros commented Dec 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

pythonmagic commented Dec 4, 2016

Uh oh!

dgarros commented Dec 4, 2016

Uh oh!

dgarros Dec 4, 2016

Choose a reason for hiding this comment

Uh oh!

dgarros Dec 4, 2016

Choose a reason for hiding this comment

Uh oh!

dgarros Dec 4, 2016

Choose a reason for hiding this comment

Uh oh!

dgarros Dec 4, 2016

Choose a reason for hiding this comment

Uh oh!

pythonmagic commented Dec 4, 2016

Uh oh!

dgarros commented Dec 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants