Full macOS support and other work #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `--config-directory`, `--games-directory` parameters. - Allow configuring with environment variables. BREAKING: - Options with choices use hyphens. Ex: `--game lotro_preview` -> `--game lotro-preview` - `--startup-script` -> `--startup-scripts` - Shell completions need to be reinstalled.
The CLI doesn't accept extra arguments, so this can only cause unexpected behavior.
Just running the full logic of CaseInsensitiveAbsolutePath isn't far from the most optimum way of handling how any given path could potentially be either case sensitive or insensitive on Windows and macOS.
Neither of these should have ever actually activated. This is just making that explicit.
Fixes some context menu stuff.
Makes it harder to inspect things.
Exit code still won't be right, though.
…_config` Now that the install dir may be inside the game config dir, we need to make sure that it isn't deleted on game config reset.
It's more broadly validating the game dir before lauch, but patching being needed is the only case that wouldn't have already halted intitialization.
This option may eventually be enitrely removed. It was originally needed for a long irrelevant DDO issue.
Same icon as the install game window.
The official games servers finally work with the standard cipher set!
To see if the user is allowed to join the world.
It doesn't seem to work anymore. Not with a Trio checkpoint either.
It is used by Trio when running processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.