Skip to content

Use typed Channels for allcells, allleaves, allparents to fix type instability #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cserteGT3 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use typed Channels for allcells, allleaves, allparents to fix type instability #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3c3625
use typed channels for cell querying functions
cserteGT3 Nov 21, 2025
e0b9eb4
add tests to verify typed channels
cserteGT3 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/cell.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,8 @@ end
end
end

function allcells(cell::Cell)
Channel() do c
function allcells(cell::Cell{Data, N, T, L}) where {Data, N, T, L}
Channel{Cell{Data, N, T, L}}() do c
queue = [cell]
while !isempty(queue)
current = pop!(queue)
Expand All @@ -107,8 +107,8 @@ function allcells(cell::Cell)
end
end

function allleaves(cell::Cell)
Channel() do c
function allleaves(cell::Cell{Data, N, T, L}) where {Data, N, T, L}
Channel{Cell{Data, N, T, L}}() do c
for child in allcells(cell)
if isleaf(child)
put!(c, child)
Expand All @@ -117,8 +117,8 @@ function allleaves(cell::Cell)
end
end

function allparents(cell::Cell)
Channel() do c
function allparents(cell::Cell{Data, N, T, L}) where {Data, N, T, L}
Channel{Cell{Data, N, T, L}}() do c
queue = [cell]
while !isempty(queue)
current = pop!(queue)
Expand Down
38 changes: 38 additions & 0 deletions test/cell.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,41 @@ end
split!(root)
@test length(root.children) == 8
end

@testset "allcells, alleaves, allparents functions" begin
struct MyRefinery <: RegionTrees.AbstractRefinery
tolerance::Float64
end

function RegionTrees.needs_refinement(r::MyRefinery, cell)
maximum(cell.boundary.widths) > r.tolerance
end

function RegionTrees.refine_data(r::MyRefinery, cell::Cell, indices)
boundary = child_boundary(cell, indices)
"child with widths: $(boundary.widths)"
end

r = MyRefinery(0.5)
root = Cell(SVector(0., 0), SVector(1., 1), "root")
adaptivesampling!(root, r)

ac = allcells(root)
@test typeof(ac) == Channel{Cell{String, 2, Float64, 4}}
acv = collect(ac)
@test typeof(acv) == Vector{Cell{String, 2, Float64, 4}}
@test size(acv, 1) == 5

al = allleaves(root)
@test typeof(al) == Channel{Cell{String, 2, Float64, 4}}
alv = collect(al)
@test typeof(alv) == Vector{Cell{String, 2, Float64, 4}}
@test size(alv, 1) == 4

leaf = alv[1]
ap = allparents(leaf)
@test typeof(ap) == Channel{Cell{String, 2, Float64, 4}}
apv = collect(ap)
@test typeof(apv) == Vector{Cell{String, 2, Float64, 4}}
@test size(apv, 1) == 1
end
Loading