update regex to support multiline in julia-console#285
update regex to support multiline in julia-console#285pfitzseb merged 3 commits intoJuliaEditorSupport:masterfrom
Conversation
|
@Pangoraw could you remind me how we tested this locally? EDIT: GitHub linguist has a guide. |
|
You need nodejs and npm installed: |
|
One think I am wondering is that maybe we should put the fix in the cson file and remove the json file since Github linguist seems to work fine with cson for now. |
|
Could also consider moving the source of truth into a template file like the actual julia grammar, but tbf it doesn't really make any sense except for consistency. |
|
Ok, I updated the PR to generate a CSON file from the JSON file. The CSON file will be used by linguist (as it currently is the case). |
|
This should be live, but it looks like it didn't fix #282: julia> function bar(x)
return x
end
bar (generic function with 1 method)
julia> d = Dict(
1 => 'a',
2 => 'b',
)
Dict{Int64, Char} with 2 entries:
2 => 'b'
1 => 'a' |
|
Maybe I misconfigured something in my linguist PR? github-linguist/linguist#6859 |
|
Other changes from the grammar are not updated yet so maybe it may take time to be operational: @+ @& @<| @|> @:: @% x |
|
Maybe this is missing a release/tag? Not sure how linguist works. |
|
IIRC tags shouldn't matter at all -- the v9.2 release points to the newest commit in this repo. |
|
Looks like these are still not working: julia> function bar(x)
return x
end
bar (generic function with 1 method)
julia> d = Dict(
1 => 'a',
2 => 'b',
)
Dict{Int64, Char} with 2 entries:
2 => 'b'
1 => 'a'@+ @& @<| @|> @:: @% x |
cc @adrhill