Skip to content

Conversation

@susham
Copy link

@susham susham commented Aug 30, 2017

Review for Implementation of ProjectSubmissionOutputFileParser

…ed some better error checking for the score entered by the Grader.
…l the uncaught exception handler in the project submission scorer application.
DavidWhitlock and others added 23 commits July 23, 2017 19:41
…been set yet, give it full credit (max points).
…ring-ui

Demonstrate that Susham can get his code into my repository.
…oring-ui' into issue-208-project-submissions-scoring-ui
…s-scoring-ui

Issue 208 project submissions scoring ui
…s-scoring-ui

Get upstream changes from Dave
@DavidWhitlock
Copy link
Collaborator

@susham, instead of making a Pull Request against my master branch, how about you make a pull request against my branch for issues #208?

https://github.com/DavidWhitlock/PortlandStateJava/compare/issue-208-project-submissions-scoring-ui...susham:issue-208-project-submissions-scoring-ui?expand=1

That way, the Pull Request will only contain the changes made on your branch, not all of the changes that have been made (by you and me) to support issue #208. It will help me focus on providing you with feedback on your changes.

@DavidWhitlock
Copy link
Collaborator

Let's use #218 to track these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants