Open
Conversation
…top processing early. Also removes two warnings about unused enums.
…_ prefix to the unused write_output function to suppress related warning
… tests for `get_simulation_params` and the new function that use the provided test case
… CLI eventually. For now, suppresses the progress bar during tests
…ce the size of the match statement and improve readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds:
cli.rs,routing.rs, andmain.rs.cli.rsandconfig.rs.main.rsthat verifies the test case works as expected.Modifies:
OUTPUT_TYPEvariable tomain.rsalong with a match statement to suppress rustc's warnings about unused enum elements. This should serve as a placeholder until the relevant features are added._config_dirvariable to the main function in `main.rs' to suppress the warnings about the CLI Config struct config_dir member going unused. Given that using the configuration data is on the roadmap, this was preferable to outright removal.routing.rsto suppress unused variable warnings.PR likely is not complete, as there are probably additional areas that need error handling added.