Allow setting :ip and :port from gorilla-options.#5
Open
jvtrigueros wants to merge 1 commit intoJonyEpsilon:developfrom
Open
Allow setting :ip and :port from gorilla-options.#5jvtrigueros wants to merge 1 commit intoJonyEpsilon:developfrom
jvtrigueros wants to merge 1 commit intoJonyEpsilon:developfrom
Conversation
Owner
|
Hi. Thanks for this, and sorry for the slow reply. It looks like a good idea, and I will merge this in once I have time to make the next release :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As is, you must pass the
:ipand:portkeys when starting the gorilla server via lein. Why can't we just allow users to set their port and ip in theirproject.clj.