Open
Conversation
JonathanHiggs
requested changes
Nov 22, 2024
Owner
JonathanHiggs
left a comment
JonathanHiggs
left a comment
There was a problem hiding this comment.
Sorry, but I don't want to commit a large blob to the repo like that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
identfield's size is not constrained, whereas the thread identifier field of a ThreadDescriptor in perfetto is. It is generally meant to match the platform thread identifier's size, so usingnative_idis more appropriate. It will also be more meaningful in the perfetto UI.