Make short-circuiting old version deployments more robust to snapshotting #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/robust-snapshot-reverts
branch
from
661b817 to
8211ab9
Compare
area
force-pushed
the
maint/robust-snapshot-reverts
branch
3 times, most recently
from
2d05b41 to
01e689d
Compare
Member
Author
|
I've also cherry-picked a commit changing |
area
force-pushed
the
maint/robust-snapshot-reverts
branch
2 times, most recently
from
1b68e2d to
29f94dd
Compare
kronosapiens
reviewed
Oct 1, 2024
Contributor
kronosapiens
left a comment
kronosapiens
left a comment
There was a problem hiding this comment.
This can't have been an easy bug to catch, bravo
area
force-pushed
the
maint/robust-snapshot-reverts
branch
3 times, most recently
from
7198324 to
9e67f9e
Compare
kronosapiens
force-pushed
the
maint/robust-snapshot-reverts
branch
from
9e67f9e to
4f89877
Compare
kronosapiens
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran across this issue when writing a test in #1285 when adding a test to
colony.js. There, old versions of contracts are deployed at the end of the test file, and as a result if transactions fromaccounts[0]are added to previous tests, they get deployed to different addresses.Those addresses are recorded in
deployOldUpgradeableVersionand reused if deemed appropriate. The check to whether they are appropriate or not is whether there is code at that address. The current codebase appears to have stumbled up to the edge of, but not into, the regime where the old versions deployed incolony.jsoverlap with the contracts deployed inmeta-colony.js. By adding an extra transaction in the former, overlap occurs.That means that when the address that we recorded deploying
hmwssat is checked, there is code there and it's attempted to be reused; but it's actually a Token and so the tests fail.By resetting the recorded addresses when we do a revert in the fixture, everything is brought in line again.