Remove setExpenditureValues #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
As requested in #1252, this also brings over the constant we introduced to make the assembly done with metatransactions easier to understand. |
area
force-pushed
the
maint/remove-set-expenditure-values
branch
from
a392306 to
7819b1a
Compare
area
force-pushed
the
maint/remove-set-expenditure-values
branch
from
7819b1a to
b19af4b
Compare
kronosapiens
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend no longer relies on
setExpenditureValues(usingmulticall, instead which didn't exist when we originally implemented that function) so as agreed, we can removesetExpenditureValuesinstead of fixing its interaction with metatransactions.This replaces #1252 , and is currently based on #1258 which should be reviewed and merged first.