-
Notifications
You must be signed in to change notification settings - Fork 113
Streaming payments only support a single stream #1250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a54bad to
a17d2b7
Compare
kronosapiens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. I still don't love all the extra logic about pseudo claims, etc which we added to allow admins to change payout rates, but that's not what this PR is about.
fc1cdaa to
a78f8c2
Compare
c0ee585 to
5a5ae87
Compare
|
NB Now based on #1262 |
5a5ae87 to
89fe76c
Compare
|
What's with all the storage file changes? Does the PR need a rebase? Also is this ready to go off draft? |
|
It does not need rebasing. The one change in |
kronosapiens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
NB Based on maint/pnpm.
Multiple streams in a single streaming payment are no longer desired on the frontend, so taking the opportunity to simplify the contracts. This will also allow accurate tracking of the number of pending payments, allowing the 'prevent uninstall if pending payments' feature.
I've taken advantage of
finishUpgradeto make sure someone can't upgrade from v4 to v5, which we are declaring is impossible due to the storage layout changes.