-
Notifications
You must be signed in to change notification settings - Fork 114
Expenditures extension, utilities, updates #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75b91ff to
27f50b4
Compare
558f8bc to
7895b5e
Compare
5d2198e to
f520243
Compare
1790070 to
a10ad27
Compare
area
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move the creation of ColonyRewards in to a new PR that could be reviewed (presumably quickly) separately? I find it very hard to keep track of what's changed when large chunks also move around.
d15bad5 to
a1354bb
Compare
496a283 to
7672b73
Compare
51daa24 to
377d00e
Compare
377d00e to
758a208
Compare
area
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of low-hanging fruit, branch-coverage wise, on setExpenditureValues. Don't just rest on the laurels of my commit you've cherry picked ;). Same for the new moveFundsBetweenPots.
This PR more or less solves two-out-of-three issues that I brought up in #1031... should it solve the third as well (i.e. the claim delay stuff)? Or leave that for another PR?
Cancelling an expenditure currently has no influence on reputation, which it is spec'd as (having the option of) doing.
3d45e9d to
b79d9b1
Compare
Closes #1042
StakedExpenditurefor creating expenditures via stakes, and reclaiming or slashing stakesAlso:
moveFundsBetweenPotswhich accept arrays of tokens & amountsrefundDomainprivate function which returns excess funding back to the domain on claiming of paymentsetExpenditureValuesfunction which can change all expenditure values in one transaction, for ownerssetExpenditurePayoutfunction to update slot payouts with correct bookkeeping, for arbitratorsThe introduction of
setExpenditurePayoutaddresses a bug in the existing implementation, where usingsetExpenditureStateto update payouts would allow the funding pot bookkeeping to fall out of sync.setExpenditurePayoutas an arbitration function provides an alternative for arbitrators (with an eye towards motions) to update payouts with correct bookkeeping. This introduction has necessitated an update toVotingReputationto correctly handle both types of expenditure state changes.