Skip to content

Conversation

@iamsamgibbs
Copy link
Contributor

@iamsamgibbs iamsamgibbs commented Oct 31, 2024

@iamsamgibbs iamsamgibbs self-assigned this Oct 31, 2024
@iamsamgibbs iamsamgibbs marked this pull request as ready for review October 31, 2024 15:27
@iamsamgibbs iamsamgibbs requested a review from a team October 31, 2024 16:14
Copy link

@mmioana mmioana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a pleasure to go through these changes @iamsamgibbs 🤩

Reaaaaally nice work 💯

Tested as part of the CDapp PR

Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we talked last week, this shares a lot of code with #32 but I'll handle merging the logic together when I get to merge that.

Everything else looks good. Nicely done!

@rdig rdig merged commit 7c767ec into master Nov 6, 2024
@rdig rdig deleted the fix/3508-notifications-do-not-load-when-switching-wallets branch November 6, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants