-
Notifications
You must be signed in to change notification settings - Fork 8
Allow running stylua as an optional step #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running stylua as an optional step #58
Conversation
|
Thanks, this makes sense to me! Do you mind adding a quick smoketest to the github CI check with Also, could you update the README? |
ec78d9f to
1204822
Compare
|
I added a smoketest that adds a file that contains a stylua issue then used |
|
Yup, looks good. Just to double clarify, how do you use stylua manually afterwards - I assume it's available on the PATH so you can just reference |
Yes, I call stylua indirectly, via make. See https://github.com/ColinKennedy/nvim-best-practices-plugin-template/blob/main/Makefile. Repository structures tend to vary but using make as a bit of indirection means I can call |
1204822 to
51d5c9d
Compare
|
@JohnnyMorganz I'm not sure what caused https://github.com/JohnnyMorganz/stylua-action/actions/runs/12738986339/job/35542812438?pr=58 to fail but in case it was because of a difference in newline, I removed that code. Would you let me know if you need me to do anything else for this PR? |
|
Looks like it might be line endings issues. I can take a look at that on the weekend, but otherwise LGTM |
|
@JohnnyMorganz any chance we can move forward with this PR? |
|
Hey, very sorry for the delay here. Completely forgot about this. I've made some very small tweaks to the README and test, but it should be good now. Turns out the failure was because we need to commit the Thank you for the contribution! |
Closes: #57
Example: