This repository was archived by the owner on Apr 12, 2025. It is now read-only.
Add support for long double #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @JohnTitor |
Owner
|
Looks fine, could you also add a test case here? https://github.com/JohnTitor/ctest2/tree/master/testcrate/src |
Contributor
Author
|
From what I can read, it's supposed to compare the rust equivalent, however |
Owner
|
I wanted to ensure that it works fine by replicating code from the above libc PR, doesn't it make much sense? If not, I'm fine to merge as-is. |
Contributor
Author
|
I can give it a try at least. |
GuillaumeGomez
force-pushed
the
long-double
branch
from
e445b44 to
6f6312c
Compare
Contributor
Author
|
Let's see how it goes now. :3 |
GuillaumeGomez
force-pushed
the
long-double
branch
16 times, most recently
from
829797b to
ec4aa50
Compare
GuillaumeGomez
force-pushed
the
long-double
branch
from
ec4aa50 to
1bb9d26
Compare
Contributor
Author
|
@JohnTitor Does the test looks ok to you? |
Contributor
Author
|
Thanks for the release! :) |
tgross35
pushed a commit
to tgross35/ctest2
that referenced
this pull request
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for rust-lang/libc#2565.