feature: changes the output delivery mechanism from base64-encoded data to file storage with signed URLs #63
+1,116
−1,372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This is a major architectural refactoring that changes the output delivery mechanism from base64-encoded data to file storage with signed URLs. The system now stores generated assets to a persistent storage directory and provides time-limited signed URLs for client access, improving scalability and reducing memory overhead.
Key changes:
- Replaces base64 data in API responses with signed URLs for file downloads
- Introduces centralized configuration using pydantic-settings
- Adds file storage infrastructure with signed URL generation
- Updates all workers to save outputs to storage instead of returning base64
Reviewed changes
Copilot reviewed 98 out of 98 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| workers/common/config.py | New centralized settings with storage directory configuration |
| api/common/storage.py | New signed URL generation and verification system |
| api/files/router.py | New file serving endpoint with signature validation |
| workers/workflows/context.py | Refactored to save files to storage with task-based naming |
| workers/videos/context.py | Updated video saving to use storage directory |
| workers/images/context.py | Updated image saving to use storage directory |
| api/*/schemas.py | Changed response schemas from base64_data to URL lists |
| docker-compose*.yml | Added storage volume configuration |
| clients/*/utils.py | Changed from base64 decoding to URL downloads |
| tests//test_.py | Updated to check for output URLs instead of base64 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JoeGaffney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.