Allow empty service endpoint, use default region endpoint. #19
Open
pennyclip wants to merge 4 commits intoJetBrains:masterfrom
Open
Allow empty service endpoint, use default region endpoint. #19pennyclip wants to merge 4 commits intoJetBrains:masterfrom
pennyclip wants to merge 4 commits intoJetBrains:masterfrom
Conversation
added 4 commits
August 1, 2018 14:11
…uld not be forced to use a custom endpoint, rather have the option to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Second attempt at this one)
Hey Crew,
Back again with another small change suggestion. While we were testing the plugin to first deploy to multiple regions at the same time, we also wanted to have the choice for us to deploy to a particular region. It would be nice if we could do this without having to parameterize the region AND the service endpoint, or make another configuration.
The code already determines if the service endpoint is not empty when it is looking to build the client, and it should work just fine with region alone.
If there are concerns about making this optional, I would love to hear that feedback. Thanks for your time.
Jon