Draft
Conversation
…hema references - Removed the User type in favor of AuthenticatedUser across multiple schemas. - Updated GraphQL queries and mutations to reflect the new type. - Adjusted resolver implementations to return AuthenticatedUser instead of User. - Introduced AnonymousUser type for handling unauthenticated users. - Ensured backward compatibility by updating union types and references in generated files.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit 69c8b20
☁️ Nx Cloud last updated this comment at |
github-actions
bot
had a problem deploying
to
Preview - journeys-admin
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
github-actions
bot
requested a deployment
to
Preview - journeys-admin
Contributor
|
The latest updates on your projects.
|
Contributor
|
The latest updates on your projects.
|
github-actions
bot
requested a deployment
to
Preview - journeys-admin
…d schema references - Introduced AnonymousUser type to handle unauthenticated users across multiple schemas. - Updated User type to be a union of AuthenticatedUser and AnonymousUser. - Adjusted resolver implementations and references in user-related schemas to accommodate the new structure. - Ensured compatibility with existing queries and mutations by updating relevant types.
… are processed - Modified various components to check for AuthenticatedUser type before accessing user properties. - Updated user-related logic in JourneyVisitorsPage, AccessDialog, and Team components to enhance type safety. - Ensured consistent handling of user data across the application by filtering out non-authenticated users.
- Changed instances of User type to AuthenticatedUser in JourneyAppearance, JourneyCardMenu, TeamOnboarding, UserTeamInviteForm, and useUserTeamsAndInvitesLazyQuery tests. - Ensured consistency in user type handling across multiple test files.
…d schema references - Changed the User type in UserTeam to reference the new User union, which includes both AuthenticatedUser and AnonymousUser. - Introduced AnonymousUser type in multiple schemas to handle unauthenticated users. - Updated generated TypeScript files to reflect the changes in the GraphQL schema. - Ensured consistency across the application by updating user-related logic to accommodate the new structure.
…t components - Updated user type checks in AccessDialog and Host components to use optional chaining for safer access to user properties. - Ensured consistent handling of AuthenticatedUser type across components to prevent potential runtime errors.
- Removed conditional check for 'menu-item' variant and signed-in status in handleCheckSignIn function. - Streamlined the logic to always set loading state and call handleCustomizeNavigation, improving code clarity.
- Removed UserRole type and its associated queries from the journeys schema, streamlining user role management. - Introduced a new UserRole type in the modern journeys schema to enhance clarity and maintainability. - Updated references to UserRole across various components and modules, ensuring consistency in user role handling. - Adjusted the team creation logic to accommodate guest users, improving the user experience for unauthenticated access.
- Removed getJourneyProfile query from the legacy journeys schema to streamline the API. - Added getJourneyProfile query to the modern journeys schema, ensuring consistency in data retrieval across different schemas.
- Included quickStartTemplate in the main seeding function to enhance initial data setup. - This addition supports improved onboarding and user experience by providing a quick start option.
- Removed the adminJourneys query from the legacy journeys schema to streamline the API. - Added the adminJourneys query to the modern journeys schema, ensuring consistency in data retrieval. - Updated related resolver and generated TypeScript files to reflect the changes, enhancing maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.