Fix resource leak causing CI test hangs in AsyncReplayBuffer #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JerrettDavis <2610199+JerrettDavis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI tests running indefinitely in pipeline
Fix resource leak causing CI test hangs in AsyncReplayBuffer
Jan 27, 2026
JerrettDavis
approved these changes
Jan 27, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Test Results244 tests 244 ✅ 1m 49s ⏱️ Results for commit d5bed2d. |
Contributor
Code Coverage |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 85.20% 87.18% +1.97%
==========================================
Files 152 164 +12
Lines 14002 15331 +1329
Branches 1923 2122 +199
==========================================
+ Hits 11931 13366 +1435
- Misses 1576 1965 +389
+ Partials 495 0 -495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🔍 PR Validation ResultsVersion: `` ✅ Validation Steps
📊 ArtifactsDry-run artifacts have been uploaded and will be available for 7 days. This comment was automatically generated by the PR validation workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI tests hang indefinitely (1h+ timeouts) due to a waiter leak in
AsyncReplayBuffer<T>.TryGetAsync().Root Cause
When a cancellation token fires, the
TaskCompletionSourcewaiter is cancelled but never removed from_waiters. Orphaned waiters accumulate, breaking the producer logic which expects_waiters.Count == 1. Subsequent calls deadlock asshouldProduceis never set.Changes
src/PatternKit.Core/Behavioral/Iterator/AsyncFlow.cs
Cancellation tests now complete in ~100ms instead of hanging. All 1,762 tests pass.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.