Switch to Visual Studio 2019, disabled Screen Resolution Modification, added handling for the two GUID flags and added "return address" to log of interface calls#2
Open
TheRedDaemon wants to merge 2 commits intoJeremyAnsel:masterfrom
Conversation
TheRedDaemon
commented
May 19, 2021
TheRedDaemon
commented
- The two possible GUID flags DDCREATE_EMULATIONONLY and DDCREATE_HARDWAREONLY were not handled before.
- Resolution Modification caused issues at least with the game "Stronghold Crusader"
- Return address is received by using the intrinsic _ReturnAddress.
- Found no method to get application call address of exported functions.
…DrawCreate - the modifications broke for example "Stronghold Crusader"
JeremyAnsel
reviewed
May 21, 2021
| str << this << " " << __FUNCTION__; | ||
| str << " " << dwWidth << "x" << dwHeight << " " << dwBPP; | ||
|
|
||
| /* @TheRedDaemon: removed modification, intention is to see what it normally does, or not? |
Owner
There was a problem hiding this comment.
Instead of commenting out the display mode modification, I would prefer to have a #define config, maybe in common.h.
Owner
|
Hello, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.