Cleaned up code #51
Open
Cleaned up code #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sult-and-clean-up Fix icon cleanup The deletion of the allocated icon buffer in GUI::fetchIcon was unreachable. The function now stores the created icon handle, cleans up the buffer, and then returns the handle. Updated GUI::fetchIcon to ensure the icon buffer is freed before returning the icon handle
…urn-rect-width-and-height Fix getDimensions calculation fix the order of width and height returned by getDimensions
…-for-.mpk-support Add MoviePack support to GUI extraction support .mpk archives in Interface file map expose ArchiveMoviePack file table lookup containing archive for any file type document GUI capability for .mpk extraction
…r-case-sensitivity Fix case-sensitive include paths fix include path casing for Fileutils and Numutils correct WindowComponent header include casing
Fix missing newline at EOF
…readme Fix README typos
…tract-methods Add CLI progress output show extraction progress in CLI increment progress on every batch file
…andling-for-.mpk-support Add MoviePack support to GUI extraction support .mpk archives in Interface file map expose ArchiveMoviePack file table lookup containing archive for any file type document GUI capability for .mpk extraction fix extension checks in archive factory
…rator-function Fix include path case for Linux builds
…-future--wait_for Refactor async polling and build fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just cleaned up some stuff. :)