Conversation
…n for improved transcription accuracy
…n for improved transcription accuracy
…ion and correction validation
…d clarify functionality
|
@greptile |
There was a problem hiding this comment.
Pull request overview
This pull request introduces "audiov2" - a major feature update that adds Cloudflare AI as the default transcription provider, implements a migration system for database schema management, adds voice activity detection (VAD), text alignment functionality, and edit analytics tracking. The PR also renames the Base10 provider to "Auto" provider and removes the langgraph TypeScript worker implementation.
Changes:
- Adds Cloudflare Workers AI as default transcription backend with Base10 as fallback option
- Implements SQL migration system for database schema versioning
- Adds new VAD module, text alignment module, and edit analytics tracking
- Renames Base10 provider to Auto provider (flow-worker handles provider selection)
- Removes flow-worker-langgraph TypeScript implementation
- Adds comprehensive test coverage for storage, FFI, and end-to-end pipelines
Reviewed changes
Copilot reviewed 55 out of 59 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| flow-worker/wrangler.toml | Updated worker name, added AI binding and transcription provider config |
| flow-worker/src/lib.rs | Added Cloudflare AI integration, proper noun extraction, routing logic |
| flow-worker/README.md | New documentation (contains outdated references to Base10) |
| flow-core/src/storage.rs | Added migration system, edit analytics, learned words sessions |
| flow-core/src/migrations.rs | New migration management system |
| flow-core/src/vad.rs | New voice activity detection module |
| flow-core/src/alignment.rs | New text alignment module (not shown in diff) |
| flow-core/src/providers/auto.rs | Renamed from base10.rs, updated URLs |
| flow-core/src/ffi.rs | Added alignment, edit analytics, and undo FFI functions |
| flow-core/tests/*.rs | Added comprehensive test coverage |
| flow-worker-langgraph/* | Deleted entire TypeScript worker |
| Sources/FlowApp/WaveformView.swift | Changed animation interval from 1/30 to 1/107 |
Files not reviewed (1)
- flow-worker-langgraph/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
To use Codex here, create a Codex account and connect to github. |
|
To use Codex here, create a Codex account and connect to github. |
|
bruh |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 69 out of 74 changed files in this pull request and generated 6 comments.
Files not reviewed (1)
- flow-worker-langgraph/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
Sources/FlowApp/WaveformView.swift:92
- The code removes the assignment
let colors = colorCache ?? ColorCache(barCount: barCount)but the removed variablecolorswas likely used later in the rendering loop. This will cause a compilation error unlesscolorsis no longer needed. Verify that this removal doesn't break the waveform rendering.
let normalizationFactor = max(0.3, windowMax)
let bufferFilling = sampleBuffer.count < barCount
for i in 0 ..< barCount {
let x = startX + CGFloat(i) * (barWidth + gap)
// Get sample for this bar and apply log scale normalization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace SELECT-then-INSERT with atomic UPSERT using corrections.occurrences + 1, then read back actual count to recompute confidence. Eliminates TOCTOU race on concurrent writes. - Strip leading/trailing punctuation before correction cache lookup so "teh," correctly matches "teh" and produces "the,". - Fix test assertions that documented bugs instead of testing correct behavior.
# Conflicts: # flow-core/src/learning.rs
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 59 out of 63 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
No description provided.