Skip to content

fix MockLensRequest with Nova 5 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kichetof wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix MockLensRequest with Nova 5 #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Lenses/MockLensRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace JoshGaber\NovaUnit\Lenses;

use Illuminate\Contracts\Database\Eloquent\Builder;
use Laravel\Nova\Http\Requests\LensRequest;

class MockLensRequest extends LensRequest
Expand All @@ -17,14 +18,14 @@ public function __construct(array $query = [], array $request = [], array $attri
$this->withOrdering = false;
}

public function withFilters($query)
public function withFilters(Builder $query): Builder
{
$this->withFilters = true;

return $query;
}

public function withOrdering($query, $defaultCallback = null)
public function withOrdering(Builder $query, $defaultCallback = null): Builder
{
$this->withOrdering = true;

Expand Down