This repository was archived by the owner on Dec 6, 2025. It is now read-only.
Updated database schema to v2 and updated tests acordingly#6
Merged
AtomicAlexD merged 3 commits intostagefrom May 23, 2025
Merged
Updated database schema to v2 and updated tests acordingly#6AtomicAlexD merged 3 commits intostagefrom
AtomicAlexD merged 3 commits intostagefrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the database schema to version 2 by replacing the budget-related functionalities with user-related ones and updating corresponding tests and UI logic.
- Renames SQL queries, test functions, and data handler methods from budget to user.
- Updates the home page to work with user data instead of budgets.
- Revises the database schema YAML to add a new user table and modify foreign key relationships accordingly.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/test_data_handler.py | Updated test functions and SQL queries to reference the user table. |
| src/front/home.py | Modified UI endpoints and flash messages to use user names. |
| src/data_handler.py | Renamed and adjusted database functions to handle users. |
| src/config_files/verity_schema.yaml | Updated schema definitions to include the user table and adjust foreign keys. |
Files not reviewed (1)
- src/front/templates/home.html: Language not supported
Comments suppressed due to low confidence (2)
src/front/home.py:33
- [nitpick] Consider correcting the capitalization in the flash message to 'User name not saved, please check the logs' for consistency.
flash("user Name not saved, please check the logs", "error")
src/config_files/verity_schema.yaml:15
- [nitpick] Ensure consistency in table naming conventions; if other tables use plural names, consider renaming 'account_type' to 'account_types' or updating others for uniformity.
- table_name: account_type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type:
1. Title: [Database v2 upgrade]
2. Description:
3. Checklist:
[x] I have followed the project's coding style and conventions.
[x] I have written unit tests to cover my changes.
[x] My code has been tested locally.
[x] I have included screenshots/GIFs if applicable.
[x] I have updated the documentation (if necessary).
[x] I have labeled this PR appropriately (e.g., "bug," "feature," "refactor").
4. Reviewer Notes (Optional - Add if you have specific requests)