Refacctor emulation + MC sampling modules, dev + package modernization #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdm.lock was becoming too much trouble, so just fully switch over to uv
Can add back if it seems necessary, but for now, just adds many dependencies
Still trying to decide what is most communicative
No changes in functionality
Need to decide whether I back off from staticmethods, but the idea is reasonable
Maybe the names won't exactly stick, but I think it's useful to split these up to avoid confusion. base is related to the individual emulator, while interface is related to the actual use of emulator(s)
I don't think it will be available from the config directly, so better to pass it
Need to merge now to collect some changes
Should be ready for first testing
Otherwise, this will cause ruff format to break the file (by ending the module docstring early by using """) or escaping the quotes will break blacken-docs. So just ignore those lines and move on
Mostly done, although still a few fixes to be done later
Make them more consistent (fixes a typo in formatting)
No code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accumulated development changes:
Still some is a WIP, but would like to get this merged in sooner rather than later since this touches a lot of files