Updates to commands API, and merging in master changes. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
place to do shit rather than in the wantRedraw override. Changing window params from the draw callback can crash in VR, so don't do it.
Since the OSD is considered a "transient" thing only needed to alert the user to something that has gone wrong, or notification-like update to something that just happened, it has no logic to go in or out of VR mode. It stays in VR or in 2D simply where it was created.
for writability, the lookup exception now carries the dataref name for the exception's what()
… plugins for apple silicon
Added the commands files to CMake, made the API more modern (in my personal opinion), and added more error checking to avoid UB. Signed-off-by: Julia DeMille <me@jdemille.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've robustified the proposed
CommandsAPI, added it to CMake, and brought in changes from upstreammaster. Intended to augment PhilippMuenzel#8.