Make library inkcpp_shared public #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, using add_subdirectory or FetchContent requires linking inkcpp_shared to inkcpp_compiler to avoid missing headers (e.g., config.h). This is counterintuitive, because the installed library does not require this target, and it breaks the simple find_package(inkcpp) workflow.
Owner
|
Thanks for the PR, got spotted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, using
add_subdirectoryorFetchContentin a CMake project fails to compile. The compiler reports missing headers from the inkcpp_shared library. A workaround is to explicitly link it:However, this is only a quick fix.
Problem
inkcpp_shared is a header-only library defined as an
INTERFACEtarget and is used in the public headers of the inkcpp and inkcpp_compiler projects. However, both projects link inkcpp_shared as aPRIVATEdependency, which prevents its headers from being propagated to consumers.This issue is not visible when inkcpp is installed, because the public headers from inkcpp_shared are copied during installation.
Solution
To fix the problem, inkcpp_shared should be linked
PUBLICso that its headers are properly propagated as part of the public API of both inkcpp and inkcpp_compiler.