Added Intake Subsystem #22
Conversation
ngarnsworthy
left a comment
ngarnsworthy
left a comment
There was a problem hiding this comment.
Your code looks good you just need to complete these tasks. Also after you merge #17 update the README.md.
TeamCode/src/main/java/org/firstinspires/ftc/teamcode/commands/RunIntake.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Get Nate to approve #17 and then rebase this branch against main and move all magic values (I.E. 1, "intakeMotor") to the Constants class.
There was a problem hiding this comment.
This has not been done or you have failed to push
| intake = new Intake(hardwareMap, "intakeMotor"); | ||
|
|
||
| coOp.getGamepadButton(GamepadKeys.Button.A).whileHeld(new RunShooter(shooter, 1)); | ||
| coOp.getGamepadButton(GamepadKeys.Button.B).whileHeld(new RunIntake(intake, 0.5)); |
There was a problem hiding this comment.
Also add this functionality to BackupOpMode (needs aforementioned merge and rebase).
There was a problem hiding this comment.
You have not done this. If you resolve a comment without a fix comment as to why you are resolving
Removed isFinished method from RunIntake command as it is default
ngarnsworthy
left a comment
ngarnsworthy
left a comment
There was a problem hiding this comment.
You only fixed one of my comments
|
I made a new branch from the new formatting and got it correct, but didnt create a pull request. I’ll do that when I can. |
|
Ok you can close this MR then |
No description provided.