Conversation
Owner
|
oo! thanks so much, I like this and want to accept it. I will do detailed code review when I get the chance, it may be a little while. |
|
You don't need enabling XFixes extension for such basic shape usage. A following call would suffice. XShapeCombineRectangles(theDisplay, theWindow, ShapeInput, 0, 0, NULL, 0, ShapeSet, YXBanded);Which roughly translates to: set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a window manager that uses the "Focus Follows Mouse" mode, oneko is focused every time it reaches the mouse. If focused, oneko will consume all mouse events, which is sometimes annoying. For example, if I click a button and oneko is laying under the mouse, this click event will be sent to oneko but not the button. I have to first move the mouse to somewhere to drive away oneko, and try to click the button before it comes back.
This patch tries to solve this problem by making oneko click-through. All events that oneko received will be simply passed through. This feature depends on X11
XFixedextension, which means we need to add-lXfixedto our compile options.