Skip to content

Conversation

@github-actions
Copy link
Contributor

closes #39

@peterbarancek peterbarancek marked this pull request as ready for review January 27, 2026 08:09
Copilot AI review requested due to automatic review settings January 27, 2026 08:09
@peterbarancek peterbarancek merged commit f2f72b9 into dev Jan 27, 2026
1 check passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds new suspend functionality to the TcoDo component in the TcoElements library, allowing conditional suspension of digital output signals. The changes enable users to temporarily disable outputs based on runtime conditions with appropriate warning messages.

Changes:

  • Added two new methods (Suspend and SuspendExpression) to conditionally suspend digital output signals
  • Introduced a new private field _sb of type TcoCore.StringBuilder for message formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<Declaration><![CDATA[(*~
<docu>
<summary>
Suspend the turning to next position when the condition is 'true'. Task is still bussy
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'bussy' to 'busy'.

Suggested change
Suspend the turning to next position when the condition is 'true'. Task is still bussy
Suspend the turning to next position when the condition is 'true'. Task is still busy

Copilot uses AI. Check for mistakes.
</summary>
<remarks>
<note type="warning">
The call of this method will be effective only when called AFTER the initialization of the instance of given TcoCarousel.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation references 'TcoCarousel' but this method is in the TcoDo component. This appears to be copy-pasted documentation that should be updated to reference TcoDo instead.

Suggested change
The call of this method will be effective only when called AFTER the initialization of the instance of given TcoCarousel.
The call of this method will be effective only when called AFTER the initialization of the instance of given TcoDo.

Copilot uses AI. Check for mistakes.
(*~
<docu>
<summary>
Condition to suspend the movement of the carousel can be inverted by this parameter.
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation references 'carousel' but this is a digital output component (TcoDo), not a carousel. Update documentation to reflect the actual component purpose.

Copilot uses AI. Check for mistakes.
]]></Declaration>
<Implementation>
<ST><![CDATA[IF (_setTask.Busy OR _signal ) AND inDisableCondition THEN
Messenger.Warning(CONCAT('<#Ouput signal is suspended due to#> : ' , inMessage));
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected spelling of 'Ouput' to 'Output'.

Suggested change
Messenger.Warning(CONCAT('<#Ouput signal is suspended due to#> : ' , inMessage));
Messenger.Warning(CONCAT('<#Output signal is suspended due to#> : ' , inMessage));

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[NEW-FEATURE] Add SetSignal method to TcoDo component in TcoElements library

1 participant