THUND-174: Default to immediate initialization of the association#233
THUND-174: Default to immediate initialization of the association#233
Conversation
jebentier
left a comment
There was a problem hiding this comment.
I'm not following the root cause need for this change. What changed that made this necessary to be supported? Can we just remove includes of LargeTextField::Owner in models that don't use the large_text_field? Likely that was missed in a migration off of large text field in the past.
|
I probably would have done that, but the offending code was in a different gem, and I was trying to minimize the foot print of my changes. This also keeps the gem semantically the same as it was in 1.2. The other gem is oauth_provider |
|
So it's easier to update this gem, over the other gem? But also, what changed that made this edge case in the first place? This and the |
|
Sorry I thought I replied, but something failed. I made the 1.3 version, that changed the semantics which exposed the issue, so I wanted to "fix" that. But I think you are correct that updating the oauth gem is the correct path. |
https://invoca.atlassian.net/browse/THUND-174
For some reason oauth_provider uses the large_text_field gem; however, it does not actually define any fields. Adjust the gem to support this use case.