Skip to content

TECH-17399: switch out rr for rspec-mocks #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jebentier merged 1 commit into from
Feb 4, 2025
Merged

TECH-17399: switch out rr for rspec-mocks #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ gem 'minitest', '~> 5.1'
gem 'minitest-reporters'
gem 'mysql2'
gem 'pry'
gem 'rr', '~> 1.1'
gem 'rspec-expectations'
gem 'rspec-mocks'
gem 'rubocop', require: false
gem 'rubocop-minitest', require: false
gem 'rubocop-rails', require: false
Expand Down
12 changes: 10 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@
GEM
remote: https://rubygems.org/
specs:
actioncable (6.1.7.3)

Check failure on line 11 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L11 

          actionpack
          Warning Message: https://discuss.rubyonrails.org/t/cve-2023-28362-possible-xss-via-user-supplied-values-to-redirect-to/83132
          CVE:             CVE-2023-28362
          Severity:        medium

Check failure on line 11 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L11 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-fwhr-88qx-h9g7
          CVE:             CVE-2024-28103
          Severity:        medium

Check failure on line 11 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L11 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-x76w-6vjr-8xgj
          CVE:             CVE-2024-41128
          Severity:

Check failure on line 11 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L11 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-vfg9-r3fq-jvx4
          CVE:             CVE-2024-47887
          Severity:

Check failure on line 11 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L11 

          actionpack
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-vfm5-rmrh-j26v
          CVE:             CVE-2024-54133
          Severity:
actionpack (= 6.1.7.3)

Check failure on line 12 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L12 

          activesupport
          Warning Message: https://github.com/rails/rails/releases/tag/v7.0.7.1
          CVE:             CVE-2023-38037
          Severity:        medium
activesupport (= 6.1.7.3)
nio4r (~> 2.0)
websocket-driver (>= 0.6.1)
actionmailbox (6.1.7.3)
actionpack (= 6.1.7.3)
activejob (= 6.1.7.3)
activerecord (= 6.1.7.3)

Check failure on line 19 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L19 

          activestorage
          Warning Message: https://discuss.rubyonrails.org/t/possible-sensitive-session-information-leak-in-active-storage/84945
          CVE:             CVE-2024-26144
          Severity:        medium
activestorage (= 6.1.7.3)
activesupport (= 6.1.7.3)
mail (>= 2.7.1)

Check failure on line 22 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L22 

          actionmailer
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-h47h-mwp9-c6q6
          CVE:             CVE-2024-47889
          Severity:
actionmailer (6.1.7.3)
actionpack (= 6.1.7.3)
actionview (= 6.1.7.3)
Expand All @@ -29,16 +29,16 @@
rails-dom-testing (~> 2.0)
actionpack (6.1.7.3)
actionview (= 6.1.7.3)
activesupport (= 6.1.7.3)

Check failure on line 32 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L32 

          rack
          Warning Message: https://discuss.rubyonrails.org/t/denial-of-service-vulnerability-in-rack-content-type-parsing/84941
          CVE:             CVE-2024-25126
          Severity:        medium

Check failure on line 32 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L32 

          rack
          Warning Message: https://discuss.rubyonrails.org/t/possible-dos-vulnerability-with-range-header-in-rack/84944
          CVE:             CVE-2024-26141
          Severity:

Check failure on line 32 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L32 

          rack
          Warning Message: https://discuss.rubyonrails.org/t/possible-denial-of-service-vulnerability-in-rack-header-parsing/84942
          CVE:             CVE-2024-26146
          Severity:
rack (~> 2.0, >= 2.0.9)
rack-test (>= 0.6.3)
rails-dom-testing (~> 2.0)
rails-html-sanitizer (~> 1.0, >= 1.2.0)

Check failure on line 36 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L36 

          actiontext
          Warning Message: https://github.com/rails/rails/security/advisories/GHSA-wwhv-wxv9-rpgw
          CVE:             CVE-2024-47888
          Severity:
actiontext (6.1.7.3)
actionpack (= 6.1.7.3)
activerecord (= 6.1.7.3)
activestorage (= 6.1.7.3)
activesupport (= 6.1.7.3)

Check failure on line 41 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L41 

          nokogiri
          Warning Message: https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-r95h-9x8f-r3f7
          CVE:             GHSA-r95h-9x8f-r3f7
          Severity:

Check failure on line 41 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L41 

          nokogiri
          Warning Message: https://github.com/sparklemotion/nokogiri/security/advisories/GHSA-xc9x-jj77-9p9j
          CVE:             GHSA-xc9x-jj77-9p9j
          Severity:
nokogiri (>= 1.8.5)
actionview (6.1.7.3)
activesupport (= 6.1.7.3)
Expand Down Expand Up @@ -82,6 +82,7 @@
concurrent-ruby (1.3.4)
crass (1.0.6)
date (3.3.3)
diff-lcs (1.5.1)
erubi (1.12.0)
globalid (1.1.0)
activesupport (>= 5.0)
Expand Down Expand Up @@ -162,9 +163,15 @@
thor (~> 1.0)
rainbow (3.1.1)
rake (13.0.6)
regexp_parser (2.8.0)

Check failure on line 166 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L166 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-vg3r-rm7w-2xgh
          CVE:             CVE-2024-35176
          Severity:        medium

Check failure on line 166 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L166 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-4xqq-m2hx-25v8
          CVE:             CVE-2024-39908
          Severity:        medium

Check failure on line 166 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L166 

          rexml
          Warning Message: https://www.ruby-lang.org/en/news/2024/08/01/dos-rexml-cve-2024-41123
          CVE:             CVE-2024-41123
          Severity:        medium

Check failure on line 166 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L166 

          rexml
          Warning Message: https://www.ruby-lang.org/en/news/2024/08/01/dos-rexml-cve-2024-41946
          CVE:             CVE-2024-41946
          Severity:        medium

Check failure on line 166 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L166 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-vmwr-mc7x-5vc3
          CVE:             CVE-2024-43398
          Severity:        medium

Check failure on line 166 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L166 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-2rxp-v6pw-ch6m
          CVE:             CVE-2024-49761
          Severity:        high
rexml (3.2.5)
rr (1.2.1)
rspec-expectations (3.13.3)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-mocks (3.13.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.2)
rubocop (1.50.2)
json (~> 2.3)
parallel (~> 1.10)
Expand Down Expand Up @@ -225,7 +232,8 @@
mutex_m (>= 0.3.0)
mysql2
pry
rr (~> 1.1)
rspec-expectations
rspec-mocks
rubocop
rubocop-minitest
rubocop-rails
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails_6_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "mysql2"
gem "pry"
gem "rr", "~> 1.1"
gem "rspec-expectations"
gem "rspec-mocks"
gem "rubocop", require: false
gem "rubocop-minitest", require: false
gem "rubocop-rails", require: false
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails_6_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "mysql2"
gem "pry"
gem "rr", "~> 1.1"
gem "rspec-expectations"
gem "rspec-mocks"
gem "rubocop", require: false
gem "rubocop-minitest", require: false
gem "rubocop-rails", require: false
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails_7_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "mysql2"
gem "pry"
gem "rr", "~> 1.1"
gem "rspec-expectations"
gem "rspec-mocks"
gem "rubocop", require: false
gem "rubocop-minitest", require: false
gem "rubocop-rails", require: false
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "mysql2"
gem "pry"
gem "rr", "~> 1.1"
gem "rspec-expectations"
gem "rspec-mocks"
gem "rubocop", require: false
gem "rubocop-minitest", require: false
gem "rubocop-rails", require: false
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails_7_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "mysql2"
gem "pry"
gem "rr", "~> 1.1"
gem "rspec-expectations"
gem "rspec-mocks"
gem "rubocop", require: false
gem "rubocop-minitest", require: false
gem "rubocop-rails", require: false
Expand Down
3 changes: 2 additions & 1 deletion gemfiles/rails_8_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ gem "minitest", "~> 5.1"
gem "minitest-reporters"
gem "mysql2"
gem "pry"
gem "rr", "~> 1.1"
gem "rspec-expectations"
gem "rspec-mocks"
gem "rubocop", require: false
gem "rubocop-minitest", require: false
gem "rubocop-rails", require: false
Expand Down
3 changes: 2 additions & 1 deletion test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
require "minitest/unit"
require "pry"
require "rails/test_help"
require "rr"
require 'rspec/mocks/minitest_integration'
require 'rspec/expectations/minitest_integration'
require "shoulda"
require 'minitest/reporters'

Expand Down
2 changes: 1 addition & 1 deletion test/unit/large_text_field/owner_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ class OwnerTest < ActiveSupport::TestCase

new_value = Library.includes(:large_text_fields).find(@library.id)

dont_allow(Library.connection).select
expect(Library.connection).not_to receive(:select)

assert_equal "first", new_value.description
assert_equal "second", new_value.catalog
Expand Down