WEB-8121: depend on diff-lcs so that we can share the global namespace

[dcaddell]

[0.6.1]

Fixed

• Fixed a global namespace collision with diff-lcs over the Diff constant

Added

• Loading invoca/utils/diff now gives access to both invoca-utils and diff-lcs diff helpers

Demo

Tested this change locally with the call_artifact_push repo

--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,3 +1,10 @@
+PATH
+  remote: ../invoca-utils
+  specs:
+    invoca-utils (0.6.0)
+      activesupport (>= 6.0)
+      diff-lcs (>= 1.6.1)
+
 PATH
   remote: .
   specs:
@@ -167,7 +174,7 @@ GEM
-    diff-lcs (1.5.1)
+    diff-lcs (1.6.1)

> bundle exec rspec
/Users/dcaddell/invoca/invoca-utils/lib/invoca/utils.rb:23: warning: already initialized constant Diff
/Users/dcaddell/.rbenv/versions/3.1.6/lib/ruby/gems/3.1.0/gems/diff-lcs-1.6.1/lib/diff/lcs.rb:3: warning: previous definition of Diff was here
.........................................................................................................................................................................................................................................................................................................................................

Finished in 1.83 seconds (files took 2.61 seconds to load)
329 examples, 0 failures

Coverage report generated for RSpec to /Users/dcaddell/invoca/call_artifact_push/spec/results/coverage/coverage.json. 1120 / 1145 LOC (97.82%) covered.
Coverage report generated for RSpec to /Users/dcaddell/invoca/call_artifact_push/spec/results/coverage. 1120 / 1145 LOC (97.82%) covered.

[dcaddell]

This has the side-effect of adding a "previously initialized constant" warning to the logs whenever invoca-utils is loaded. See the demo for an example. Is that amount of noise a deal breaker?

[jebentier]

Nice! Looks good!