Tech 18196 fix bug in value validations and expand functionality of timestamps dsl

[jebentier]

[2.3.3] - Unreleased

Changed

• The timestamps DSL method to create created_at and updated_at columns now defaults to null: false for datetime columns
• The timestamps DSL method to allow additional options to be passed to the datetime fields

Fixed

• Fixed a bug where #validate methods on core object classes with required arguments were cuasing model validations to fail

[ttstarck]

Is this a breaking change? Will this cause all created_at and updated_at fields to need migrations?

[jebentier]

🤔 It could be considered breaking, but there is the ability to have previous functionality by using timestamps null: true to override the new default. I think that's enough to not require the breaking change bump, but not strongly opposed.

[ttstarck]

It could be considered breaking but there is the ability to have previous functionality by using timestamps null: true to override the new default

This is definitely breaking since it requires code changes, its just good practice to provide an easy way of going back to old behavior 😅. This should also be a minor version at the minimum since this is adding new functionality too.

I don't know if other people are really using this gem besides invoca but if there are, we should definitely make this a breaking change.

Or we can split this into two PRs:

1. Minor version bump: Add new functionality of passing options to timestamp fields.
2. Major version bump: Change default value of null: true to null: false

[ttstarck]

If you don't think there are other users of our gem, I'm fine with doing this as a minor version bump

[jebentier]

That's a good point. Dependents graph says only 4 other users, so minor seems good for this

[jebentier]

But, I agree we should follow best practice here. I'll cut it as major. fd8668e

[ttstarck]

Just one final fix for a typo in the changelog