Skip to content

Add support for Ruby 3.4#6

Merged
ishakun merged 3 commits intomainfrom
TECH-17382_test_ruby_3-4_on_public_gems
Feb 20, 2025
Merged

Add support for Ruby 3.4#6
ishakun merged 3 commits intomainfrom
TECH-17382_test_ruby_3-4_on_public_gems

Conversation

@dcaddell
Copy link
Contributor

Changes

  • Use the shared github workflow for testing

This PR was generated using turbolift.

@coveralls
Copy link

coveralls commented Feb 14, 2025

Pull Request Test Coverage Report for Build 13400922114

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13063525246: 0.0%
Covered Lines: 30
Relevant Lines: 30

💛 - Coveralls

@ishakun
Copy link
Contributor

ishakun commented Feb 14, 2025

@dcaddell the old build.yml file has Coveralls step:

- name: Coveralls
      if: ${{ matrix.gemfile == 'Gemfile' }}
      uses: coverallsapp/github-action@master
      with:
        github-token: ${{ secrets.github_token }

Do we want to keep it or is it ok to delete it (by deleting the build.yml file)?

I tried to use it in the new pipeline but my tests failed - I m not sure how to get the matrix.gemfile value from the tests step to then pass it to the coveralls step.

@ishakun
Copy link
Contributor

ishakun commented Feb 18, 2025

@dcaddell I added a separate Github Workflow for the Coveralls test coverage similar to how you did in a different repo. Here is the commit bd9e090

@ishakun ishakun marked this pull request as ready for review February 18, 2025 22:10
@ishakun ishakun requested a review from a team as a code owner February 18, 2025 22:10
@ishakun ishakun requested a review from yinonrousso February 18, 2025 22:10
Copy link

@yinonrousso yinonrousso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ishakun ishakun merged commit 9a6a7b4 into main Feb 20, 2025
22 of 24 checks passed
@dcaddell dcaddell deleted the TECH-17382_test_ruby_3-4_on_public_gems branch February 21, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants