Skip to content

Add Support for Ruby 3.4 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ttstarck merged 6 commits into from
Jan 31, 2025
Merged

Add Support for Ruby 3.4 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
055f0c4
Add base64, bigdecimal, and mutex_m to gemfiles to support Ruby 3.4
ttstarck Jan 28, 2025
7c995e1
Add concurrent-ruby to gemfiles to fix tests in Rails < 7.1
ttstarck Jan 28, 2025
d6a558a
use optimistic flag for bundle add
ttstarck Jan 28, 2025
46ea41d
regenerate gemfiles
ttstarck Jan 28, 2025
13643a9
fix appraisals | add new gemfiles | test new ruby versions | remove o…
ttstarck Jan 30, 2025
a10a79b
exclude ruby 3.1 and rails 8
ttstarck Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,16 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.7, '3.0', 3.1, 3.2]
ruby: [3.1, 3.2, 3.3, 3.4]
gemfile:
- Gemfile
- gemfiles/activerecord_6_0.gemfile
- gemfiles/activerecord_6_1.gemfile
- gemfiles/activerecord_7_0.gemfile
- gemfiles/activerecord_7_1.gemfile
- gemfiles/activerecord_7_2.gemfile
- gemfiles/activerecord_8_0.gemfile
exclude:
- ruby: 3.1
gemfile: gemfiles/activerecord_8_0.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
steps:
Expand Down
13 changes: 2 additions & 11 deletions Appraisals
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
# frozen_string_literal: true

appraise 'activerecord-6-0' do
gem 'activerecord', '~> 6.0.0'
end

appraise 'activerecord-6-1' do
gem 'activesupport', '~> 6.1.0'
end

appraise 'activerecord-7-0' do
gem 'activerecord', '~> 7.0.0'
end
require "appraisal/matrix"
appraisal_matrix(activerecord: "7.0")
9 changes: 9 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ source "https://rubygems.org"
gemspec

gem "appraisal"
gem "appraisal-matrix"
gem "csv"
gem "rake"
gem 'rspec'
gem 'rspec_junit_formatter'
Expand All @@ -16,3 +18,10 @@ gem 'ruby-prof'
gem 'ruby-prof-flamegraph'
gem 'simplecov'
gem 'simplecov-lcov'


gem "concurrent-ruby", "~> 1.3", "< 1.3.5"

gem "base64", ">= 0.1.1"
gem "bigdecimal", ">= 3.1"
gem "mutex_m", ">= 0.1.2"
15 changes: 13 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,14 @@
bundler
rake
thor (>= 0.14.0)
appraisal-matrix (0.3.0)
appraisal (~> 2.2)
ast (2.4.2)
base64 (0.1.1)
bigdecimal (3.1.4)
concurrent-ruby (1.2.2)
concurrent-ruby (1.3.4)
connection_pool (2.4.1)
csv (3.3.2)
diff-lcs (1.5.0)
docile (1.4.0)
drb (2.1.1)
Expand All @@ -51,7 +54,7 @@
racc (1.7.1)
rainbow (3.1.1)
rake (13.0.6)
regexp_parser (2.8.2)

Check failure on line 57 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L57 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-vg3r-rm7w-2xgh
          CVE:             CVE-2024-35176
          Severity:        medium

Check failure on line 57 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L57 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-4xqq-m2hx-25v8
          CVE:             CVE-2024-39908
          Severity:        medium

Check failure on line 57 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L57 

          rexml
          Warning Message: https://www.ruby-lang.org/en/news/2024/08/01/dos-rexml-cve-2024-41123
          CVE:             CVE-2024-41123
          Severity:        medium

Check failure on line 57 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L57 

          rexml
          Warning Message: https://www.ruby-lang.org/en/news/2024/08/01/dos-rexml-cve-2024-41946
          CVE:             CVE-2024-41946
          Severity:        medium

Check failure on line 57 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L57 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-vmwr-mc7x-5vc3
          CVE:             CVE-2024-43398
          Severity:        medium

Check failure on line 57 in Gemfile.lock

View check run for this annotation

Security Scanner as a Service / Bundle Audit

Gemfile.lock#L57 

          rexml
          Warning Message: https://github.com/ruby/rexml/security/advisories/GHSA-2rxp-v6pw-ch6m
          CVE:             CVE-2024-49761
          Severity:        high
rexml (3.2.6)
rspec (3.12.0)
rspec-core (~> 3.12.0)
Expand Down Expand Up @@ -104,11 +107,19 @@

PLATFORMS
arm64-darwin-22
arm64-darwin-23
arm64-darwin-24
x86_64-linux

DEPENDENCIES
activerecord-data_classification!
appraisal
appraisal-matrix
base64 (>= 0.1.1)
bigdecimal (>= 3.1)
concurrent-ruby (~> 1.3, < 1.3.5)
csv
mutex_m (>= 0.1.2)
rake
rspec
rspec-mocks
Expand All @@ -121,4 +132,4 @@
simplecov-lcov

BUNDLED WITH
2.4.17
2.6.2
6 changes: 6 additions & 0 deletions gemfiles/activerecord_7_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
source "https://rubygems.org"

gem "appraisal"
gem "appraisal-matrix"
gem "csv"
gem "rake"
gem "rspec"
gem "rspec_junit_formatter"
Expand All @@ -13,6 +15,10 @@ gem "ruby-prof"
gem "ruby-prof-flamegraph"
gem "simplecov"
gem "simplecov-lcov"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
gem "base64", ">= 0.1.1"
gem "bigdecimal", ">= 3.1"
gem "mutex_m", ">= 0.1.2"
gem "activerecord", "~> 7.0.0"

gemspec path: "../"
8 changes: 7 additions & 1 deletion gemfiles/activerecord_6_0.gemfile → gemfiles/activerecord_7_1.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
source "https://rubygems.org"

gem "appraisal"
gem "appraisal-matrix"
gem "csv"
gem "rake"
gem "rspec"
gem "rspec_junit_formatter"
Expand All @@ -13,6 +15,10 @@ gem "ruby-prof"
gem "ruby-prof-flamegraph"
gem "simplecov"
gem "simplecov-lcov"
gem "activerecord", "~> 6.0.0"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
gem "base64", ">= 0.1.1"
gem "bigdecimal", ">= 3.1"
gem "mutex_m", ">= 0.1.2"
gem "activerecord", "~> 7.1.0"

gemspec path: "../"
8 changes: 7 additions & 1 deletion gemfiles/activerecord_6_1.gemfile → gemfiles/activerecord_7_2.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
source "https://rubygems.org"

gem "appraisal"
gem "appraisal-matrix"
gem "csv"
gem "rake"
gem "rspec"
gem "rspec_junit_formatter"
Expand All @@ -13,6 +15,10 @@ gem "ruby-prof"
gem "ruby-prof-flamegraph"
gem "simplecov"
gem "simplecov-lcov"
gem "activesupport", "~> 6.1.0"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
gem "base64", ">= 0.1.1"
gem "bigdecimal", ">= 3.1"
gem "mutex_m", ">= 0.1.2"
gem "activerecord", "~> 7.2.0"

gemspec path: "../"
24 changes: 24 additions & 0 deletions gemfiles/activerecord_8_0.gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "appraisal"
gem "appraisal-matrix"
gem "csv"
gem "rake"
gem "rspec"
gem "rspec_junit_formatter"
gem "rspec-mocks"
gem "rubocop"
gem "rubocop-git"
gem "ruby-prof"
gem "ruby-prof-flamegraph"
gem "simplecov"
gem "simplecov-lcov"
gem "concurrent-ruby", "~> 1.3", "< 1.3.5"
gem "base64", ">= 0.1.1"
gem "bigdecimal", ">= 3.1"
gem "mutex_m", ">= 0.1.2"
gem "activerecord", "~> 8.0.0"

gemspec path: "../"
Loading