-
Notifications
You must be signed in to change notification settings - Fork 748
Add counters to Pablo's integration of the defensive mempool #6420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: defensive-mempool
Are you sure you want to change the base?
Conversation
2363a53 to
b7b14b0
Compare
|
@mgmeier Does this look like a sufficient way to add new EKG counters? |
|
As of the current tip, |
cardano-tracer/src/Cardano/Tracer/Handlers/RTView/State/Historical.hs
Outdated
Show resolved
Hide resolved
|
An additional word about The new metrics this PR implements will - without any change to |
mgmeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new metrics implementation LGTM! Thank you @nfrisby.
0dbb8ac to
4a93aa2
Compare
f4e457f to
47d5510
Compare
Description
Adding EKG metrics for the soft and hard timeouts in the new defensive mempool feature.
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.