refactor(ci): update upgrade scripts for config consistency #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkoura
commented
Jan 5, 2026
mkoura
commented
- Move export of PATH_PREPEND_BASE and PATH_PREPEND_UPGRADE to after all assignments in node_upgrade.sh for clarity and correctness.
- Remove legacy mode variables in node_upgrade_pytest.sh as non-P2P mode is no longer supported.
- Standardize config and topology generation steps to use new dry_config_step2 and dry_config_step3 directories instead of legacy mixed/p2p naming.
- Improve output by using readlink -m for node binary paths and add explicit labels for clarity.
- Minor comments and capitalization fixes for consistency.
- Move export of PATH_PREPEND_BASE and PATH_PREPEND_UPGRADE to after all assignments in node_upgrade.sh for clarity and correctness. - Remove legacy mode variables in node_upgrade_pytest.sh as non-P2P mode is no longer supported. - Standardize config and topology generation steps to use new dry_config_step2 and dry_config_step3 directories instead of legacy mixed/p2p naming. - Improve output by using readlink -m for node binary paths and add explicit labels for clarity. - Minor comments and capitalization fixes for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.