Defensive mempool #1327
Open
Defensive mempool #1327
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
requested review from
a team,
Jimbo4350,
carbolymer,
disassembler,
kevinhammond and
newhoggy
as code owners
This was referenced Jan 23, 2026
carbolymer
reviewed
Jan 26, 2026
| DebugNodeConfigNoConwayFileCmdError fp -> | ||
| "Conway genesis file not specified in " | ||
| <> pretty fp | ||
| <> ". Please add a \"ConwayGenesisFile\" key to the file at " |
Contributor
There was a problem hiding this comment.
DebugNodeConfigNoConwayHashCmdError is not needed anymore. Also, I've bumped cardano-cli to latest api's master here: https://github.com/IntersectMBO/cardano-cli/pull/1326/files
carbolymer
reviewed
Jan 26, 2026
| checkHashIfPresent shelleyGenFile actualShelleyHash mExpectedShelleyHash | ||
| checkHashIfPresent conwayGenFile actualConwayHash mExpectedConwayHash | ||
| where | ||
| ifJustAndDifferent :: Eq a => a -> (a -> CIO e ()) -> Maybe a -> CIO e () |
Contributor
There was a problem hiding this comment.
This function is too complicated tbh. It would be better to just use for_ instead of it
Contributor
Author
There was a problem hiding this comment.
Yes, I saw your PR just after writing this, and I think your solution is much nicer. I will cherry-pick it and/or rebase on top of it when your PR is merged
Contributor
Author
palas
force-pushed
the
defensive-mempool
branch
from
89b1a5d to
dd03c5a
Compare
palas
force-pushed
the
defensive-mempool
branch
from
c13540f to
966e34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stanzas must be removed before merging!
Changelog
Context
This PR updates
cardano-apito use the latest version of ouroboros-consensus that includes this patch: IntersectMBO/ouroboros-consensus#1836Related PRs:
How to trust this PR
Changes are small, but worth checking they make sense if you have good context about them.
Checklist