Skip to content

TxBodyContent refactoring related fixes #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Jimbo4350 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

TxBodyContent refactoring related fixes #1093

Jimbo4350 wants to merge 2 commits into from
+95 −50

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Jan 28, 2026 •
edited
Loading

Changelog

Resolves:

- description: |
    TxBodyContent refactoring related fixes
  type:
  - breaking      

  projects:
   - cardano-api

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/tx-body-content-refactoring-fixes branch from 6d19014 to 8a02481 Compare January 28, 2026 18:51
@Jimbo4350 Jimbo4350 force-pushed the jordan/tx-body-content-refactoring-fixes branch from 2f27bcb to 94d2bf5 Compare January 28, 2026 20:44
Jimbo4350
Jimbo4350 commented Jan 28, 2026
View reviewed changes
cardano-api/src/Cardano/Api/Experimental/Tx/Internal/BodyContent/New.hs
toLedgerDatum (OldApi.TxOutDatumHash _ (Api.ScriptDataHash h)) = L.DatumHash h
toLedgerDatum (OldApi.TxOutSupplementalDatum _ h) =
case L.makeBinaryData $ SBS.toShort $ Api.getOriginalScriptDataBytes h of
Left e -> error $ show e
Copy link
Contributor Author

@Jimbo4350 Jimbo4350 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert to Either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts will be requested when the pull request is marked ready for review dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd will be requested when the pull request is marked ready for review erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

@palas palas Awaiting requested review from palas palas will be requested when the pull request is marked ready for review palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara will be requested when the pull request is marked ready for review CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jimbo4350