-
Notifications
You must be signed in to change notification settings - Fork 9
feat: disable the graph #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes all usages of the legacy GraphClient, replaces graph-based event fetching with the new Intmax event server API, and updates configuration accordingly.
- Add a new
event_server_urlconfiguration option and removegraph_url/timeout. - Remove all
GraphClientimports and related helper functions (sync, health checks, sleeps). - Introduce
get_deposit_eventsinexternal_api::intmax::eventto fetch deposited events.
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/config.rs | Added event_server_url; dropped graph_url and timeout. |
| src/external_api/intmax/event.rs | New module to fetch deposit events from the event server. |
| src/services/assets_status.rs | Updated to use get_deposit_events instead of GraphClient. |
| src/services/sync.rs | Removed GraphClient-based sync logic from tree syncing. |
| src/services/mining | Stripped out deterministic sleep and GraphClient usage. |
| src/external_api/graph/* | Deleted legacy GraphClient code and modules. |
| config/*.toml | Bumped version, added event_server_url, removed graph_*. |
| Cargo.toml | Version bumped to 1.3.3. |
Comments suppressed due to low confidence (2)
src/utils/config.rs:40
- Add a documentation comment for the new
event_server_urlfield in theApistruct, consistent with other fields, to explain its purpose.
pub event_server_url: String,
src/external_api/intmax/event.rs:99
- Consider adding tests for error cases (e.g., invalid JSON or server errors) in
get_deposit_eventsto verify that error paths are handled correctly.
async fn test_get_deposit_events() {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.