Skip to content

Conversation

@kbizikav
Copy link
Collaborator

@kbizikav kbizikav commented Jul 2, 2025

No description provided.

@kbizikav kbizikav changed the title Disable the graph feat: disable the graph Jul 2, 2025
@kbizikav kbizikav requested a review from Copilot July 2, 2025 15:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all usages of the legacy GraphClient, replaces graph-based event fetching with the new Intmax event server API, and updates configuration accordingly.

  • Add a new event_server_url configuration option and remove graph_url/timeout.
  • Remove all GraphClient imports and related helper functions (sync, health checks, sleeps).
  • Introduce get_deposit_events in external_api::intmax::event to fetch deposited events.

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils/config.rs Added event_server_url; dropped graph_url and timeout.
src/external_api/intmax/event.rs New module to fetch deposit events from the event server.
src/services/assets_status.rs Updated to use get_deposit_events instead of GraphClient.
src/services/sync.rs Removed GraphClient-based sync logic from tree syncing.
src/services/mining Stripped out deterministic sleep and GraphClient usage.
src/external_api/graph/* Deleted legacy GraphClient code and modules.
config/*.toml Bumped version, added event_server_url, removed graph_*.
Cargo.toml Version bumped to 1.3.3.
Comments suppressed due to low confidence (2)

src/utils/config.rs:40

  • Add a documentation comment for the new event_server_url field in the Api struct, consistent with other fields, to explain its purpose.
    pub event_server_url: String,

src/external_api/intmax/event.rs:99

  • Consider adding tests for error cases (e.g., invalid JSON or server errors) in get_deposit_events to verify that error paths are handled correctly.
    async fn test_get_deposit_events() {

kbizikav and others added 2 commits July 2, 2025 22:23
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kbizikav kbizikav merged commit 78a0387 into main Jul 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants