Skip to content

Conversation

@kbizikav
Copy link
Collaborator

No description provided.

@kbizikav kbizikav requested a review from Copilot June 24, 2025 09:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a cutoff date after which new deposits are blocked and bumps the CLI version.

  • Introduces DEPOSIT_CLOSE_TIMESTAMP constant and checks current time against it
  • Emits a warning when a deposit would occur after the cutoff
  • Updates Cargo.toml version to 1.3.1

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/services/mod.rs Implement deposit-close logic and warning output
Cargo.toml Bump version from 1.3.0 to 1.3.1
Comments suppressed due to low confidence (3)

src/services/mod.rs:19

  • Add a doc comment for DEPOSIT_CLOSE_TIMESTAMP to explain its role, e.g., /// Timestamp after which deposits are closed (2025-06-28 00:00:00 UTC).
const DEPOSIT_CLOSE_TIMESTAMP: u64 = 1751068800; // 2025-06-28 00:00:00 UTC

src/services/mod.rs:54

  • There are no tests covering the new deposit-close behavior. Please add unit or integration tests that simulate timestamps before and after DEPOSIT_CLOSE_TIMESTAMP to verify both blocking and warning logic.
        let is_open = (chrono::Utc::now().timestamp() as u64) < DEPOSIT_CLOSE_TIMESTAMP;

src/services/mod.rs:62

  • The warning string uses a multi-line literal with leading spaces, which will introduce unwanted indentation in the output. Consider using an explicit \n or a raw string literal without indentation to produce a clean message.
                You can still withdraw your deposits but cannot make new deposits.",

@smallbabybear smallbabybear merged commit b203b97 into main Jun 24, 2025
1 check passed
@kbizikav kbizikav deleted the close-deposit branch June 24, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants