Cache the value-label pairs when the picker items are fetched #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
flochtililoch
left a comment
flochtililoch
left a comment
There was a problem hiding this comment.
@Shaykoo thanks for the submission. Looking over the change, I think we need some functionality to reset that cache, to ensure we're not operating on outdated data if the underlying XML has changed.
Comment on lines
-40
to
+48
| if ( | ||
| pickerItems | ||
| .map((item: Element) => item.getAttribute('value')) | ||
| .includes(value) | ||
| ) { | ||
| const valueExists = pickerItems.some( | ||
| item => item.getAttribute('value') === value, | ||
| ); | ||
| if (valueExists) { | ||
| return value; | ||
| } | ||
| if (pickerItems.length > 0) { | ||
| return pickerItems[0].getAttribute('value') || ''; | ||
| } | ||
| return ''; | ||
| return pickerItems.length > 0 | ||
| ? pickerItems[0].getAttribute('value') || '' | ||
| : ''; |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current getLabelForValue method loops through all picker items each time it is called. This can be inefficient if you have a large list of items. Caching the mapping of values to labels will improve performance.