chore(section-list): use FlatList for SectionList #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update demo `add-styles` behavior to reduce re-renders. [Asana](https://app.asana.com/1/47184964732898/project/1205761271270033/task/1210514672776456?focus=true)
Performing an update action (append, prepend, replace, replace-inner) with a delay requires that the behavior element has an id. The `basic-forms` demo was missing an id so was non functional. - Added an error to warn developers of this condition - Fixed the demo by adding an id to the element | Before | Error | After | | -- | -- | -- | |  |  |  | [Asana](https://app.asana.com/1/47184964732898/project/1204008699308084/task/1210535376481469?focus=true)
The previous functionality was returning zero if the `scroll-to-input-offset` attribute was missing, otherwise it was returning the default value (120). There was no path which returned the value of `scroll-to-input-offset` if available. - Created a new demo "Scroll to Input Offset" - Corrected the value return - Fixed a few typos in the demo and documentation | Before | After | | -- | -- | |  |  | [Asana](https://app.asana.com/1/47184964732898/project/1204008699308084/task/1210525849054931?focus=true)
hgray-instawork
force-pushed
the
hardin/section-list-as-flat
branch
from
524f6cd to
f4361f2
Compare
Collaborator
flochtililoch
left a comment
flochtililoch
left a comment
There was a problem hiding this comment.
I see a difference in behavior between the two implementation: the sticky header pushed the previous one with SectionList, while it overlap with the previous one with FlatList. Is this something we can fine tune?
Collaborator
Author
I see the same "push up" animation in my clean react-native testbed. I'm not sure if the difference here is related to:
I'll poke around some more and see if I can get them to match. flatlist-demo.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of using a react-native
FlatListin place ofSectionListfor ourhv-section-listcomponent.All functionality is retained. Code was able to be simplified especially around the scrolling behaviors.
Asana