Conversation
Member
|
This is not the right solution to #67 ITKAnisotropicDiffusionLBR module does not need ITKIOPNG, only its example. The right solution likely involves the CMake ITK module macros. |
Member
Author
|
Can you propose an alternative? Should we keep this open until there is an alternative solution to #67? |
Member
|
I currently do not have an alternative, this can remain open, but it should not be merged because it adds an undesirable dependency on IO libraries. |
thewtex
requested changes
Nov 14, 2025
Member
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
This is an issue with the examples CMake configuration. Hacking with an unneeded main module dependency introduces an unneeded dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67. Recreation of #59.