Fix linux build #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry, I missed that you'd made a PR here, I've been busy so hadn't looked into this until tonight, but I went and updated the bindings and applied this manually (should've cherry-picked because I screwed it up the first time haha), and it seems to work on Linux and Windows. Due to how we have to branch and such to make all this work I can't apply this directly, but assuming Luna's testing comes back alright this should get in fairly soon, I won't close this until it does. Appreciate the help! Ideally we could augment the lua generator to use the define here, but I don't really want to go digging in too deep on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the failed builds for Linux (See this i2d-ingui issue).
The __cdecl macro seems to be a Windows macro, so i copied the solution found in the imgui/imgui_demo.cpp.
The Windows build has yet to be tested.