feat: Update onboarding with login logic#582
Open
LunarX wants to merge 28 commits intoprotected/st-plus-uifrom
Open
feat: Update onboarding with login logic#582LunarX wants to merge 28 commits intoprotected/st-plus-uifrom
LunarX wants to merge 28 commits intoprotected/st-plus-uifrom
Conversation
… from within the app
# Conflicts: # app/src/main/java/com/infomaniak/swisstransfer/ui/OnboardingActivity.kt # app/src/main/java/com/infomaniak/swisstransfer/ui/utils/AccountUtils.kt
baillyjamy
reviewed
Feb 17, 2026
app/src/main/java/com/infomaniak/swisstransfer/services/CrossAppLoginService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/AccountPreferences.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/AccountUtils.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| private fun loginUsersIntoTheApp(users: List<User>) { | ||
| // TODO: trackAccountEvent(MatomoName.LoggedIn) |
Contributor
There was a problem hiding this comment.
Can't you apply it now ?
app/src/main/java/com/infomaniak/swisstransfer/ui/OnboardingActivity.kt
Outdated
Show resolved
Hide resolved
…tUtils not being init quickly enough
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now ST login informations like the client id don't work so I reused the informations from mail temporarily so we can try and test the behavior.
In this PR, I added the new 4th page of the onboarding that logs in the user if they have logged in accounts in other apps or lets the user connect in "guest mode" if there are none.
I also added a fake button in the settings to try the login logic from the future "my account" screen because it goes through the OnboardingActivity and its last screen to handle login.