[algorithm] Fix bug concerning coupling point removal during retraction #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove points ahead of the tip
…on edge direction
…sts to edge element types
…ing points vector
th-skam
added
pr: status to review
epernod
requested changes
Sep 19, 2025
Contributor
epernod
left a comment
epernod
left a comment
There was a problem hiding this comment.
some conflicts to solve and should be good
Collaborator
Author
|
We're good to go |
epernod
reviewed
Sep 19, 2025
epernod
approved these changes
Sep 19, 2025
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #83
It is based on PR #89
The problem
During retraction, if the needle is moving too fast inside the tissue, the coupling points are not removed properly. The video below demonstrates the issue. This is due to the algorithm performing only one removal per time step.
25-09-11-RetractionBug.mp4
Solution
Iterate over the coupling points vector and remove points whenever necessary within the same time step. The
Operationsadditions in PR #89 make this easy to implement. The video below demonstrates the result (it is the same scene):25-09-11-RetractionFix.mp4
Additionally, flow control for point removal or addition should not necessarily be done explicitly in the algorithm. It is a bit restricting without having a big positive effect on performance.